Prepend context to parameter transformers#160
Merged
Conversation
8976465 to
ce7032d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Change the signature of parameter type transformer functions so the
TestCaseContextis prepended as the first argument. This needs a bit of gymnastics with wrapping the function in order to achieve what we want within the constraints of the cucumber-expressions API.At the same time, adopt the changes from cucumber/javascript-core#32 so we're doing a bit more of the lifting with the step arguments.
⚡️ What's your motivation?
Be consistent with step and hook functions (and the Node.js test runner itself) where we prepend the context as the first arg - enabling arrow functions by default - but still supply the world as
thisfor continuity when coming from cucumber-js.🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.